Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Project Owner in Team tab to top of members list #4021

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Conversation

mbouzi
Copy link
Contributor

@mbouzi mbouzi commented Jan 11, 2021

What: We want to make the Project Owner in Team tab pinned to the top of the list of team members

Why: More convenience for the user

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

Copy link
Member

@VitaliiShpital VitaliiShpital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProjectMembersArea unit test is failing. Could you look into it and try to fix it?

web/satellite/src/components/team/ProjectMembersArea.vue Outdated Show resolved Hide resolved
VitaliiShpital
VitaliiShpital previously approved these changes Jan 14, 2021
@mbouzi mbouzi requested a review from mobyvb January 14, 2021 15:39
mobyvb
mobyvb previously approved these changes Jan 14, 2021
Copy link
Member

@mobyvb mobyvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but they don't block approval for me.

web/satellite/src/components/team/ProjectMembersArea.vue Outdated Show resolved Hide resolved
@mobyvb mobyvb self-requested a review January 15, 2021 16:58
Copy link
Member

@mobyvb mobyvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message needs to include the prefix for what was changed (web/satellite: in this case)

@mbouzi mbouzi force-pushed the pin-project-owner branch 3 times, most recently from 720f57b to 6bca6b2 Compare January 15, 2021 20:07
@mbouzi mbouzi requested a review from mobyvb January 15, 2021 20:08
mobyvb
mobyvb previously approved these changes Jan 15, 2021
VitaliiShpital
VitaliiShpital previously approved these changes Jan 18, 2021
VitaliiShpital
VitaliiShpital previously approved these changes Jan 20, 2021
Malcolm Bouzi added 4 commits January 20, 2021 14:15
- refactor project owner variable instantion
- check for existance of owner before returning members list
- changed returned members list variable name
- add comment explaining unshift logic
@mbouzi mbouzi merged commit fa2dae0 into main Jan 21, 2021
@mbouzi mbouzi deleted the pin-project-owner branch January 21, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants