-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Project Owner in Team tab to top of members list #4021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProjectMembersArea unit test is failing. Could you look into it and try to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, but they don't block approval for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message needs to include the prefix for what was changed (web/satellite: in this case)
720f57b
to
6bca6b2
Compare
6bca6b2
to
61b6662
Compare
61b6662
to
3120887
Compare
- input missing semicolon
- refactor project owner variable instantion - check for existance of owner before returning members list
- changed returned members list variable name - add comment explaining unshift logic
3120887
to
4fd871e
Compare
What: We want to make the Project Owner in Team tab pinned to the top of the list of team members
Why: More convenience for the user
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)