Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captplanet: add ctrl+\ for dumping goroutines #416

Merged
merged 2 commits into from Oct 3, 2018
Merged

Conversation

egonelbre
Copy link
Member

No description provided.

Copy link
Member

@kaloyan-raev kaloyan-raev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so helpful! Thanks!

Added a couple of minor comments.

cmd/captplanet/main.go Outdated Show resolved Hide resolved
cmd/captplanet/main.go Show resolved Hide resolved
@egonelbre egonelbre merged commit 3b98b93 into master Oct 3, 2018
@egonelbre egonelbre deleted the dump-stack branch October 3, 2018 12:27
@jtolio
Copy link
Member

jtolio commented Oct 3, 2018

I'd prefer we don't change the behavior of sigquit especially considering we already have a different system in place that dumps goroutine stacks

@jtolio
Copy link
Member

jtolio commented Oct 3, 2018

i realize I'm too late

@egonelbre
Copy link
Member Author

We can take it out no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants