Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/draft-release.sh: use python2 for draft release #5216

Merged
merged 2 commits into from
Sep 29, 2022
Merged

scripts/draft-release.sh: use python2 for draft release #5216

merged 2 commits into from
Sep 29, 2022

Conversation

ihaid
Copy link
Member

@ihaid ihaid commented Sep 29, 2022 •
edited

What:

Why:

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@ihaid ihaid requested a review from a team September 29, 2022 12:15
@cla-bot cla-bot bot added the cla-signed label Sep 29, 2022
@andriikotko andriikotko self-requested a review September 29, 2022 12:22
@stefanbenten stefanbenten changed the title use python2 for draft release scripts/draft-release.sh: use python2 for draft release Sep 29, 2022
@ihaid ihaid merged commit 96d4968 into main Sep 29, 2022
@ihaid ihaid deleted the ig/fix branch September 29, 2022 13:22
andriikotko pushed a commit that referenced this pull request Sep 30, 2022
@ihaid @andriikotko
use python2 for draft release (#5216)
8ed8513
andriikotko pushed a commit that referenced this pull request Sep 30, 2022
@ihaid @andriikotko
use python2 for draft release (#5216)
bda2e67
dlamarmorgan pushed a commit that referenced this pull request Oct 18, 2022
@ihaid @dlamarmorgan
use python2 for draft release (#5216)
370184e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriikotko andriikotko andriikotko approved these changes

@stefanbenten stefanbenten stefanbenten approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ihaid @andriikotko @stefanbenten