New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web/satellite: update and optimize error page #6391
Conversation
Use 3x smaller size background image and update styles. Update button.
left: 0; | ||
right: 0; | ||
bottom: 0; | ||
background: url("/static/static/images/errors/world.svg") no-repeat center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this path is functional at runtime, it produces an unresolved path error when building. It should be expressed relative to the current file: ../../static/images/errors/world.svg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Jeremy!
What:
Use 3x smaller size background image and update styles. Update button.
Why:
We were updating the error page for linksharing, and using the same optimized background now updating the satellite error page. Also we are not using rounded buttons anymore.
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)