Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/satellite: update and optimize error page #6391

Merged
merged 10 commits into from Oct 10, 2023
Merged

Conversation

boshevski
Copy link
Member

What:
Use 3x smaller size background image and update styles. Update button.

Why:
We were updating the error page for linksharing, and using the same optimized background now updating the satellite error page. Also we are not using rounded buttons anymore.

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

Use 3x smaller size background image and update styles. Update button.
@boshevski boshevski enabled auto-merge (squash) October 5, 2023 17:19
left: 0;
right: 0;
bottom: 0;
background: url("/static/static/images/errors/world.svg") no-repeat center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this path is functional at runtime, it produces an unresolved path error when building. It should be expressed relative to the current file: ../../static/images/errors/world.svg.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jeremy!

egonelbre
egonelbre previously approved these changes Oct 5, 2023
@boshevski boshevski merged commit 211659b into main Oct 10, 2023
3 checks passed
@boshevski boshevski deleted the satellite-ui-error-page branch October 10, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants