Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/testplan: add account changes testplan #6817

Merged
merged 14 commits into from Mar 13, 2024

Conversation

andriikotko
Copy link
Contributor

What:
testplan for upcoming account changes
Why:
upcoming changes in project plans
Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

docs/testplan/account-changes-testplan.md Outdated Show resolved Hide resolved
docs/testplan/account-changes-testplan.md Outdated Show resolved Hide resolved
mobyvb
mobyvb previously approved these changes Feb 29, 2024
@andriikotko andriikotko requested a review from mobyvb March 5, 2024 13:22
@andriikotko andriikotko merged commit e05d427 into main Mar 13, 2024
2 checks passed
@andriikotko andriikotko deleted the ak/account-changes-testplan branch March 13, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants