RevocationDB fixes #866
RevocationDB fixes #866
Conversation
| @@ -82,21 +82,23 @@ type ServerConfig struct { | |||
| type ServerOptions struct { | |||
| Config ServerConfig | |||
| Ident *FullIdentity | |||
| RevDB *peertls.RevocationDB | |||
There was a problem hiding this comment.
It looks very weird to close "Options".
There was a problem hiding this comment.
do you have an alternate name or flow in mind?
pkg/provider/identity.go
Outdated
| @@ -294,11 +296,14 @@ func (ic IdentityConfig) Run(ctx context.Context, interceptor grpc.UnaryServerIn | |||
| if err != nil { | |||
| return err | |||
| } | |||
| defer func() { _ = opts.RevDB.Close() }() | |||
There was a problem hiding this comment.
What should we do with an error in a defer? Or should it not be in a defer?
There was a problem hiding this comment.
There's no really nice way of handling them at the moment.
One way would be to use something like:
defer func() { err = utils.CombineErrors(err, opts.RevDB.Close()) }
The other would be to manually close everywhere.
There was a problem hiding this comment.
I don't understand how your defer example would do anything useful and I'm pretty sure we want to use a defer for this
There was a problem hiding this comment.
Take a look at https://play.golang.org/p/0qh7EuHW7Ut. It relies on the behavior that you can change the returned err variable.
No description provided.