Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Sailors refactoring #378

Merged
merged 7 commits into from
Jun 30, 2022
Merged

Sailors refactoring #378

merged 7 commits into from
Jun 30, 2022

Conversation

espkk
Copy link
Member

@espkk espkk commented Jun 8, 2022

  • some refactoring
  • paths should be more randomized now
  • should fix rare ShipMan crash

@q4a q4a mentioned this pull request Jun 12, 2022
Open
26 tasks
@espkk espkk force-pushed the feature/sailors-refactoring branch from 07fb9fd to ee48981 Compare June 12, 2022 13:04
Hammie
Hammie approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@Hammie Hammie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I think it might make sense to introduce some kind of frand() function for easily getting random numbers in the [0.0-1.0] range. We seem to need that in quite a few places.

@espkk espkk merged commit 35e6945 into develop Jun 30, 2022
@espkk espkk deleted the feature/sailors-refactoring branch June 30, 2022 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hammie Hammie Hammie approved these changes

@ugeen4 ugeen4 Awaiting requested review from ugeen4 ugeen4 is a code owner

@np-c0mp1ete np-c0mp1ete Awaiting requested review from np-c0mp1ete

@mitrokosta mitrokosta Awaiting requested review from mitrokosta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@espkk @Hammie