This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 119
Replacement for last Windows-only file_system methods #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q4a
changed the title
Replacement for last Windows-only file_system methods
WIP: Replacement for last Windows-only file_system methods
Apr 9, 2021
np-c0mp1ete
suggested changes
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Please remove the ifs.cpp fix from this PR and try to add sdl2 via conan or as a submodule in the worst case.
I found way to get sdl2 via conan, but I have another question: you would like to link sdl2 statically or dynamically? |
np-c0mp1ete
suggested changes
Apr 10, 2021
q4a
force-pushed
the
fs-dev
branch
2 times, most recently
from
April 10, 2021 15:04
a4511c2
to
23c3f31
Compare
q4a
changed the title
WIP: Replacement for last Windows-only file_system methods
Replacement for last Windows-only file_system methods
Apr 10, 2021
np-c0mp1ete
suggested changes
Apr 12, 2021
…entDirectory with std::fs and _GetExecutableDirectory with SDL_GetBasePath
np-c0mp1ete
reviewed
Apr 28, 2021
np-c0mp1ete
approved these changes
Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace _CreateDirectory, _GetCurrentDirectory, _SetCurrentDirectory using std::filesystem analogs
Replace _GetExecutableDirectory with SDL_GetBasePath