Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Replacement for last Windows-only file_system methods #40

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Conversation

q4a
Copy link
Contributor

@q4a q4a commented Apr 9, 2021

Replace _CreateDirectory, _GetCurrentDirectory, _SetCurrentDirectory using std::filesystem analogs
Replace _GetExecutableDirectory with SDL_GetBasePath

@q4a q4a changed the title Replacement for last Windows-only file_system methods WIP: Replacement for last Windows-only file_system methods Apr 9, 2021
Copy link
Member

@np-c0mp1ete np-c0mp1ete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please remove the ifs.cpp fix from this PR and try to add sdl2 via conan or as a submodule in the worst case.

src/apps/ENGINE/ifs.cpp Outdated Show resolved Hide resolved
@q4a
Copy link
Contributor Author

q4a commented Apr 9, 2021

Thanks for the PR!

Please remove the ifs.cpp fix from this PR and try to add sdl2 via conan or as a submodule in the worst case.

I found way to get sdl2 via conan, but I have another question: you would like to link sdl2 statically or dynamically?

@q4a q4a force-pushed the fs-dev branch 2 times, most recently from a4511c2 to 23c3f31 Compare April 10, 2021 15:04
@q4a q4a changed the title WIP: Replacement for last Windows-only file_system methods Replacement for last Windows-only file_system methods Apr 10, 2021
@q4a q4a requested a review from np-c0mp1ete April 11, 2021 12:41
@np-c0mp1ete np-c0mp1ete requested a review from espkk April 11, 2021 22:00
src/apps/ENGINE/file_service.cpp Outdated Show resolved Hide resolved
src/apps/ENGINE/s_dbg_sourceview.cpp Outdated Show resolved Hide resolved
@np-c0mp1ete np-c0mp1ete merged commit 2d93ac6 into develop Apr 28, 2021
@np-c0mp1ete np-c0mp1ete deleted the fs-dev branch April 28, 2021 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants