fix(logging): Resolved issue with empty config values

storm-software · Dec 29, 2023 · 1b8e905 · 1b8e905
1 parent 8c3acb0
commit 1b8e905
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 18 deletions.
diff --git a/docs/api-reports/packages/logging/api-report.md b/docs/api-reports/packages/logging/api-report.md
@@ -6,7 +6,6 @@
 import { DestinationStream } from "pino";
 import { Logger } from "pino";
 import { LoggerOptions as LoggerOptions_2 } from "pino";
-import pretty from "pino-pretty";
 import { StormConfig } from "@storm-software/config-tools";
 import { Temporal } from "@js-temporal/polyfill";
 import * as z from "zod";
@@ -21,7 +20,7 @@ export const getLogLevelLabel: (logLevel: number) => LogLevelLabel;
 const getTransports: (
   config: StormConfig<"logging", LoggingConfig>,
   name?: string
-) => Logger<pretty.PrettyStream>;
+) => Logger<any>;
 export { getTransports };
 export { getTransports as getTransports_alias_1 };
 export { getTransports as getTransports_alias_2 };

diff --git a/docs/api-reports/packages/logging/documents-model.api.json b/docs/api-reports/packages/logging/documents-model.api.json
@@ -257,16 +257,7 @@
             },
             {
               "kind": "Content",
-              "text": ">, name?: string) => import(\"pino\").Logger<"
-            },
-            {
-              "kind": "Reference",
-              "text": "pretty.PrettyStream",
-              "canonicalReference": "!pretty.PrettyStream:type"
-            },
-            {
-              "kind": "Content",
-              "text": ">"
+              "text": ">, name?: string) => import(\"pino\").Logger<any>"
             }
           ],
           "fileUrlPath": "packages/logging/src/utilities/get-transports.ts",
@@ -275,7 +266,7 @@
           "name": "getTransports",
           "variableTypeTokenRange": {
             "startIndex": 1,
-            "endIndex": 8
+            "endIndex": 6
           }
         },
         {

diff --git a/packages/logging/src/composition/logger-wrapper.ts b/packages/logging/src/composition/logger-wrapper.ts
@@ -29,7 +29,7 @@ export class LoggerWrapper implements ILoggerWrapper {
   private constructor(logger: ILogger, config: LoggingConfig, name?: string) {
     this.#logger = logger;
     this.#name = name;
-    this.#config = config;
+    this.#config = config ?? { stacktrace: true };
   }
 
   /**

diff --git a/packages/logging/src/utilities/get-transports.ts b/packages/logging/src/utilities/get-transports.ts
@@ -1,5 +1,14 @@
 import { StormConfig } from "@storm-software/config-tools";
-import { isSetString } from "@storm-stack/utilities";
+import {
+  StormDateTime,
+  formatDate,
+  formatDateTime
+} from "@storm-stack/date-time";
+import {
+  EMPTY_STRING,
+  isRuntimeServer,
+  isSetString
+} from "@storm-stack/utilities";
 import { tmpdir } from "os";
 import { join } from "path";
 import pino, {
@@ -102,7 +111,7 @@ export const getTransports = (
     };
   }
 
-  /* if (isRuntimeServer()) {
+  if (isRuntimeServer()) {
     const pinoServerOptions = {
       options: {
         ...baseOptions,
@@ -128,7 +137,7 @@ Message: {msg}
       }
     };
 
-   targets.push(
+    targets.push(
       ...[
         {
           target: "pino/file",
@@ -228,7 +237,7 @@ Message: {msg}
       targets
     }),
     pretty(prettyOptions)
-  );*/
+  );
 
   return pino(pretty());
 };