fix(plugin-system): Update invokeHook method signature

storm-software · Jan 9, 2024 · f94ee01 · f94ee01
1 parent a9aa24f
commit f94ee01
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml
@@ -57,6 +57,9 @@ jobs:
       #- name: Generate configuration schema
       #  run: pnpm nx g @storm-software/workspace-tools:config-schema --outputPath=config.schema.json
 
+      - name: Add permissions to husky hooks
+        run: chmod a=rwx .husky/pre-push .husky/pre-commit .husky/post-merge .husky/post-commit .husky/post-checkout
+
       - name: Build repository packages
         run: pnpm nx run-many -t build --parallel=5
 

diff --git a/docs/api-reports/packages/plugin-system/api-report.md b/docs/api-reports/packages/plugin-system/api-report.md
@@ -164,8 +164,8 @@ class PluginManager<
   // (undocumented)
   invokeHook: (
     name: string,
-    handler: (context: TContext) => Promise<TContext> | TContext,
-    context: TContext
+    context: TContext,
+    handler?: ((context: TContext) => Promise<TContext> | TContext) | undefined
   ) => Promise<TContext>;
   // (undocumented)
   register: (provider: string) => Promise<PluginDefinition>;

diff --git a/docs/api-reports/packages/plugin-system/documents-model.api.json b/docs/api-reports/packages/plugin-system/documents-model.api.json
@@ -2123,7 +2123,7 @@
                 },
                 {
                   "kind": "Content",
-                  "text": "(name: string, handler: (context: TContext) => "
+                  "text": "(name: string, context: TContext, handler?: ((context: TContext) => "
                 },
                 {
                   "kind": "Reference",
@@ -2132,7 +2132,7 @@
                 },
                 {
                   "kind": "Content",
-                  "text": "<TContext> | TContext, context: TContext) => "
+                  "text": "<TContext> | TContext) | undefined) => "
                 },
                 {
                   "kind": "Reference",

diff --git a/packages/plugin-system/src/manager/plugin-manager.ts b/packages/plugin-system/src/manager/plugin-manager.ts
@@ -207,8 +207,8 @@ export class PluginManager<
 
   public invokeHook = async (
     name: string,
-    handler: (context: TContext) => Promise<TContext> | TContext,
-    context: TContext
+    context: TContext,
+    handler?: (context: TContext) => Promise<TContext> | TContext
   ): Promise<TContext> => {
     let listeners = [] as PluginHookFn<TContext>[];
     if (this.#hooks.has(name)) {
@@ -271,7 +271,10 @@ export class PluginManager<
       }
     }
 
-    nextContext = await Promise.resolve(handler(nextContext));
+    if (handler) {
+      nextContext = await Promise.resolve(handler(nextContext));
+    }
+
     for (const callback of callbacks) {
       nextContext = await Promise.resolve(callback(nextContext));
     }