fix issue with undefined req.method and stack being cleared

lib/ds/RequestExecutor.js

@@ -68,22 +68,23 @@ RequestExecutor.prototype.execute = function executeRequest(req, callback) {
     throw new Error('request.uri field is required.');
   }
 
-  //don't override the defaults: ensure that the options arg is request-specific:
+  // Don't override the defaults: ensure that the options arg is request-specific.
   var options = utils.shallowCopy(this.options, {});
 
-  if (req.method) { //defaults to GET
-    options.method = req.method;
-  }
+  req.method = req.method || 'GET';
+
+  options.method = req.method;
   options.uri = this.qualify(req.uri);
+
   if (req.query) {
     options.qs = req.query;
   }
+
   if (req.body && req.body.form){
     options.form = req.body.form;
-  }
-  else if (req.body) {
+  } else if (req.body) {
     options.body = req.body;
-    options.json = true; //all Stormpath resources are JSON
+    options.json = true; // All Stormpath resources are JSON
   }
 
   this.requestAuthenticator.authenticate(options);
@@ -92,7 +93,6 @@ RequestExecutor.prototype.execute = function executeRequest(req, callback) {
     if (err) {
       var wrapper = new Error('Unable to execute http request ' + req.method + ' ' + req.uri + ': ' + err.message);
       wrapper.inner = err;
-      wrapper.stack = '';
       return callback(wrapper, null);
     }
 

test/sp.ds.requestExecutor_test.js

@@ -129,6 +129,7 @@ describe('ds:', function () {
           err.should.be.an.instanceof(Error);
 
           err.should.have.property('stack')
+            .that.is.not.empty.and
             .that.is.not.null.and
             .that.is.not.undefined;