use href of response context for url reporting

stormpath · Jul 29, 2016 · f18e40d · f18e40d
1 parent b2a8458
commit f18e40d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/ds/RequestExecutor.js b/lib/ds/RequestExecutor.js
@@ -77,14 +77,15 @@ RequestExecutor.prototype.execute = function executeRequest(req, callback) {
   this.requestAuthenticator.authenticate(options);
 
   request(options, function onRequestResult(err, response, body) {
+    var responseContext = this;
     if (err) {
       var wrapper = new Error('Unable to execute http request ' + req.method + ' ' + req.uri + ': ' + err.message);
       wrapper.inner = err;
       return callback(wrapper, null);
     }
 
     if (response.statusCode > 399) {
-      return callback(new ResourceError(body || {status:response.statusCode}, {url: req.uri, method: req.method}), null);
+      return callback(new ResourceError(body || {status:response.statusCode}, {url: responseContext.href, method: req.method}), null);
     }
 
     if (response.statusCode === 201){

diff --git a/test/sp.ds.requestExecutor_test.js b/test/sp.ds.requestExecutor_test.js
@@ -107,6 +107,7 @@ describe('ds:', function () {
           err.should.be.an.instanceof(ResourceError);
           expect(body).to.be.null;
           cbSpy.should.have.been.calledOnce;
+          expect(err.url).to.equal(mockHost + uri);
           done();
         }
         cbSpy = sinon.spy(cb);