This repository has been archived by the owner on Dec 12, 2018. It is now read-only.
Access token authenticator #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarbettini
approved these changes
Jan 23, 2017
| @@ -79,6 +80,11 @@ function getCacheByHref(cacheManager, href) { | |||
| region = href.match(/customData/) ? 'customData' : (href.split('/').slice(-2)[0]); | |||
| } | |||
|
|
|||
| // if (href && href.match(/application\/[^\/]+\/authTokens\//)) { | |||
1 task
|
I made some formatting changes, but other than that, I'm 👍 for this! |
required some fixes for env hacks that are done earlier in this script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new access token authenticator, which decouples application assertions from access token assertions (authentication vs. authorization). It also adds a key resolver, which depends on a not-yet-released version of nJwt (work in progress here jwtk/njwt#43).
This authenticator will be used with the next patch release of express-stormpath, so that access tokens issued by client API will validate correctly - so long as they are issued by the same stormpath application, we will still retain that behavior, we just need to introduce the key resolving.