Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny suggestion, missing coma for readability of joint probabil… #33

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

mashu
Copy link
Contributor

@mashu mashu commented Dec 29, 2021

Tiny swap of words and coma, I think reads better.

@storopoli
Copy link
Owner

Thanks @mashu! I don't know if this will fail because of Turing.jl not being able to run in Julia 1.7.
I am almost certain that the GitHub Action is hard-coded for Julia 1.6. So we won't be running into a problem.

If this fail, I'll hold the merge until Turing is compatible with Julia 1.7.

@mashu mashu changed the title Tiny suggestion, missing coma for readability of conditional probabil… Tiny suggestion, missing coma for readability of joint probabil… Dec 29, 2021
@mashu
Copy link
Contributor Author

mashu commented Dec 29, 2021

No worries, unfortunately I had to force-push again to correct the git log, comment as the change was referring to line about joint probability. But it's corrected now.

@storopoli storopoli merged commit a0d5974 into storopoli:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants