Add {data.table} to example benchmarks for comparison #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be very cool to include {data.table} into the comparison since it is really performant and adds only one dependency. For a fair comparison the author would have to run the benchmark on the own machine, please. {data.table} is very common, as common as {dplyr}, with a very nice syntax.
|
Very nice syntax is quite subjective 😂 What if we created a footnote pointing readers towards this benchmarks on DataFrames |
|
You are absolutely right. But what I really find impressive is how performant {data.table} is in the end. I use it every day and think it could be an interesting match with Julia-folks. I would like the footnote. Thank you. |
|
I was looking into the Footnotes-reference, but I am not sure how you would prefer the note... I really think this could be a good information for your readers. |
- {data.table} version 1.14.0
- link to benchmark from the makers of {data.table}
storopoli
reviewed
May 11, 2021
storopoli
reviewed
May 11, 2021
|
Yes, the adjusted footnote is very helpful, I think. Let`s focus on Julia :) |
|
Ok, then could you make a commit with only that so that we can merge this PR? |
|
Great! Thanks @feinmann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very cool to include {data.table} into the comparison since it is really performant and adds only one dependency. For a fair comparison the author would have to run the benchmark on the own machine, please. {data.table} is very common, as common as {dplyr}, with a very nice syntax.