Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with ToC and Heading Level 4 #92

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Problem with ToC and Heading Level 4 #92

merged 1 commit into from
Oct 30, 2023

Conversation

tegedik
Copy link
Contributor

@tegedik tegedik commented Oct 30, 2023

Hi again,

This is about #90. I haven’t used Franklin.jl before but I think this issue is about how it handles heading levels in ToC. If you have a heading level 4 (####), there is a render error with only mintoclevel = 2. So, I set the maxtoclevel = 3. Changing it to maxtoclevel = 4 (with or without mintoclevel) also returns an error. Only chapters 2, 5 and 9 have level-4 headings, hence the errors in these chapters.

I created a fresh website using newsite() and encountered the same problem with heading level-4. So, I think this is a bug in Franklin.jl (or something it uses).

Copy link
Owner

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. I knew it could be a bug in Franklin.jl.
Thanks! Let's merge.

@storopoli storopoli merged commit 680a9f9 into storopoli:master Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants