Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Cython 3 in build process #102

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Switch to Cython 3 in build process #102

merged 2 commits into from
Nov 28, 2023

Conversation

djhoese
Copy link
Collaborator

@djhoese djhoese commented Nov 21, 2023

This PR doesn't necessarily address a specific issue, but rather prepares for one that I think is coming. This PR does a couple things:

  1. Makes sure that old numpy APIs are not used.
  2. Declares to numpy that it is/will be using the numpy C API in the cython module (to initialize numpy's internal API/state from my understanding).
  3. Forces Cython 3+ to be used during the build process

@djhoese djhoese added CI/Build dependencies Pull requests that update a dependency file labels Nov 21, 2023
@djhoese djhoese self-assigned this Nov 21, 2023
djhoese
djhoese commented Nov 21, 2023
View reviewed changes
pyproject.toml
@@ -1,3 +1,3 @@
[build-system]
requires = ["setuptools", "wheel", "numpy", "Cython"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that wheel is no longer needed as an explicit dependency and that setuptools should be depending on wheel internally.

mraspaud
mraspaud approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mraspaud mraspaud merged commit afbb02b into storpipfugl:master Nov 28, 2023
6 checks passed
@djhoese djhoese deleted the feature-cython3 branch November 28, 2023 20:14
@djhoese djhoese added the bug label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud approved these changes

Assignees

@djhoese djhoese

Labels
bug CI/Build dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djhoese @mraspaud