Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day0 #22

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Day0 #22

merged 3 commits into from
Nov 22, 2022

Conversation

paulinagonzalezc
Copy link
Collaborator

For the first part of the project we:

  • Chose the topic for our website and the API.
  • Set up the repository and tools.
  • Created the basic shared code on the home page: nav bar and footer.
  • Created the main part of the homepage that keeps the layout from the wireframe: display items with a basic design.

@storres20
Copy link
Owner

Hi @paulinagonzalezc,

✔️ Status: APPROVED 🏆 🎉 🎊
You have done a great job on this project, keep it up 👍 🥇. Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
congratulations! 🎉💯🌟

Top highlight 🎯
The Pull Request is following the GitHub Flow ✅
The PR title and description are professional and descriptive ✅
Linters are working properly ✅

Day 0

  • Choose the topic for your website and the API. ✅
  • Choose images, text, icons, fonts. ✅
  • Set up the repository and tools. ✅
  • Create the basic shared code on the home page. ✅

minion

(optional):

  • I suggest creating a Modules folder and dividing the main javascript for a well-organized project and for testing

@paulinagonzalezc paulinagonzalezc merged commit 952d4a2 into dev Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants