Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Comments #24

Merged
merged 11 commits into from
Nov 23, 2022
Merged

Add Comments #24

merged 11 commits into from
Nov 23, 2022

Conversation

storres20
Copy link
Owner

In this milestone I did the following activities:

  • I add "comments" branch
  • I checked the linters
  • I add styles
  • I add javascript modules for comments
  • I add dynamic html

@paulinagonzalezc
Copy link
Collaborator

✔️ Status: APPROVED 🏆 🎉 🎊

Hi @storres20 ,
You did a really great job! 💯
Congratulations! 🎉 🎉 🎉

200w

I reviewed your code and I see you completed your assigned tasks:
-Comments popup

When the popup loads, the webapp retrieves data from:
✅The selected API and shows details about the selected item.
✅The Involvement API to show the item comments.
✅When the user clicks on the "Comment" button, the data is recorded in the
✅Involvement API and the screen is updated.

You may now close this Pull Request and merge the changes!

Other highlights:
✅ Descriptive pull request message
✅ Linter error checks validated
✅ Documented work professionally
✅ Commit messages are meaningful.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

@storres20 storres20 merged commit 4da6220 into dev Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants