Skip to content

Commit

Permalink
Fix Windows 32bit package contents
Browse files Browse the repository at this point in the history
  • Loading branch information
dimkanovikov committed Feb 6, 2022
1 parent 01f93a4 commit 3d846bf
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build_starc_app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
run: |
cd build/windows
./make-exe_64.sh ${{env.APP_VERSION}}
- name: Sign app executables
uses: skymatic/code-sign-action@v1
with:
Expand All @@ -127,7 +127,7 @@ jobs:
with:
arguments: "/V3"
script-file: "build/windows/starc_64.nsi"

- name: Sign installer
uses: skymatic/code-sign-action@v1
with:
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:
run: |
cd build/windows
./make-exe_32.sh ${{env.APP_VERSION}}
- name: Sign app executables
uses: skymatic/code-sign-action@v1
with:
Expand All @@ -216,7 +216,7 @@ jobs:
with:
arguments: "/V3"
script-file: "build/windows/starc_32.nsi"

- name: Sign installer
uses: skymatic/code-sign-action@v1
with:
Expand All @@ -239,7 +239,7 @@ jobs:
path: |
build/windows/starc-setup-32.exe
build/windows/starc-32.zip
build_mac:
name: Build Mac OS X version
runs-on: macos-11
Expand Down
11 changes: 6 additions & 5 deletions build/windows/make-exe_32.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
# Rename result file to choosing version and architecture
#

ls "$VCToolsRedistDir/x86/"
2
#
# $1 - application version
#
Expand Down Expand Up @@ -64,8 +66,7 @@ cp $Qt5_Dir/plugins/sqldrivers/qsqlite.dll $EXE_APP_DIR/sqldrivers/
cp /c/Program\ Files\ \(x86\)/OpenSSL-Win32/*.dll $EXE_APP_DIR
#
# Copy msvc lib
#
cp /c/Windows/System32/msvcp140.dll $EXE_APP_DIR
cp /c/Windows/System32/msvcp140_1.dll $EXE_APP_DIR
cp /c/Windows/System32/vcruntime140.dll $EXE_APP_DIR
cp /c/Windows/System32/vcruntime140_1.dll $EXE_APP_DIR
#
cp "$VCToolsRedistDir/x86/Microsoft.VC142.CRT/msvcp140.dll" $EXE_APP_DIR
cp "$VCToolsRedistDir/x86/Microsoft.VC142.CRT/msvcp140_1.dll" $EXE_APP_DIR
cp "$VCToolsRedistDir/x86/Microsoft.VC142.CRT/vcruntime140.dll" $EXE_APP_DIR
7 changes: 3 additions & 4 deletions build/windows/make-exe_64.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ cp /c/Program\ Files/OpenSSL-Win64/*.dll $EXE_APP_DIR
#
# Copy msvc lib
#
cp /c/Windows/System32/msvcp140.dll $EXE_APP_DIR
cp /c/Windows/System32/msvcp140_1.dll $EXE_APP_DIR
cp /c/Windows/System32/vcruntime140.dll $EXE_APP_DIR
cp /c/Windows/System32/vcruntime140_1.dll $EXE_APP_DIR
cp "$VCToolsRedistDir/x64/Microsoft.VC142.CRT/msvcp140.dll" $EXE_APP_DIR
cp "$VCToolsRedistDir/x64/Microsoft.VC142.CRT/msvcp140_1.dll" $EXE_APP_DIR
cp "$VCToolsRedistDir/x64/Microsoft.VC142.CRT/vcruntime140.dll" $EXE_APP_DIR

0 comments on commit 3d846bf

Please sign in to comment.