Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Renaming a location also renames other locations that contain the first location's name #190

Open
hyuri opened this issue Aug 19, 2023 · 1 comment

Comments

@hyuri
Copy link
Contributor

hyuri commented Aug 19, 2023

Issue

I had two locations that shared part of a name:
SALA
SALA DE JANTAR

Translated to English:
ROOM
DINING ROOM

When I renamed "SALA" to "SALA DE ESTAR", "SALA DE JANTAR" was also affected, being renamed to "SALA DE ESTAR DE JANTAR".

image

image

Expectation

Starc should be smarter about keeping and renaming instances of location/character names. The renaming should not be done with a simple find & replace, instead, it should target specific unique objects (in this case, instances of location name).

In programming lingo, my intuition says every location object should keep a list of instances using the location, and then, when renaming that location, only the instances in that list are renamed. But, of course, you'll know better what should be done in your architecture.

@dimkanovikov
Copy link
Member

Good find. It’s because of trying to handle anoher case:

HOUSE and HOUSE. ROOM

and Starc thinks that you want to rename complex set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants