Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix README issues #34

Merged
merged 1 commit into from
Mar 20, 2024
Merged

docs: fix README issues #34

merged 1 commit into from
Mar 20, 2024

Conversation

Dawntraoz
Copy link
Contributor

There were 2 small mistakes in the README:

  • Wrong baseURL for the example.
  • Wrong anchor link to the Frameworks routing examples.

@Dawntraoz Dawntraoz added the documentation Improvements or additions to documentation label Mar 20, 2024
@Dawntraoz Dawntraoz requested a review from a team March 20, 2024 16:00
@Dawntraoz Dawntraoz self-assigned this Mar 20, 2024
@Dawntraoz Dawntraoz requested review from eunjae-lee, demetriusfeijoo and BibiSebi and removed request for a team March 20, 2024 16:00
BibiSebi
BibiSebi approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@BibiSebi BibiSebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking fine 🥇

@Dawntraoz Dawntraoz merged commit 0fe77ec into main Mar 20, 2024
1 check passed
@Dawntraoz Dawntraoz deleted the docs/fix-README branch March 20, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BibiSebi BibiSebi BibiSebi approved these changes

@eunjae-lee eunjae-lee Awaiting requested review from eunjae-lee eunjae-lee was automatically assigned from storyblok/plugins-team

@demetriusfeijoo demetriusfeijoo Awaiting requested review from demetriusfeijoo demetriusfeijoo was automatically assigned from storyblok/plugins-team

Assignees

@Dawntraoz Dawntraoz

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dawntraoz @BibiSebi