EXT-1434: Removing data.language.
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `data.story.language` is now used to access the language of the story.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
johannes-lindgren
requested review from
a team,
BibiSebi and
eunjae-lee
and removed request for
a team
|
@eunjae-lee @BibiSebi the build fails. I guess this is because |
Yeah can you revert the version changes? Let's just remove data.language in this PR, and deploy the library and the CLI separately. Let me guide you through that. |
eunjae-lee
requested changes
Apr 26, 2023
BibiSebi
approved these changes
Apr 27, 2023
# Conflicts: # packages/field-plugin/src/messaging/pluginMessage/containerToPluginMessage/StoryData.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removing
data.languagefrom the field plugin data.This is a breaking change that requires the library version to be bumped, which in turn requires the templates to be updated and the CLI version to be bumped.
As a replacement of
data.language, usedata.story.lang.Why?
When introduced, the thought was that this property contains the language of the Storyblok application as configured by the user's preferences. Instead, it turns out that this contains the content language. As such, use
data.story.langas a replacement.