This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Remove the max-width limitation in documentation page. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand why should it be limited to 48rem, and it sounds like a random value. I'm not really sure If It's really necessary.
|
@arunoda max width was used in previous design. We can remove this line safely. |
|
@mnmtanish go for it. |
|
yeah! |
|
The maxWidth:100% breaks my build and throws a lint error. |
|
Ok. I've the line commented but i thought this may also works. Sorry. |
|
Actually I just submitted a PR for a different issue and I wrapped the 100% in single quotes and that seemed to work. Should have tried that before I commented. |
|
@andresin87 can you remove the maxWidth line instead of making it '100%' |
|
Sure |
andresin87
added a commit
to andresin87/react-storybook-addon-info
that referenced
this pull request
Jun 30, 2016
storybook-eol#31 (comment) Delete maxWidth as suggested by @mnmtanish.
Merged
|
Published |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand why should it be limited to 48rem, and it sounds like a random value.
I'm not really sure If It's really necessary.