On click toggle

[goodmorninggoaway]

Use Case: clicking a toggle icon to view child nodes does not equal selecting that node.
Add onClickIcon to handle this case.

[coveralls]

Coverage increased (+0.01%) to 99.492% when pulling 43db623 on goodmorninggoaway:on-click-toggle into 3046fc0 on alexcurtis:master.

[witalobenicio]

How can we use that? I tried to pass an onClickIcon prop to TreeBeard component but it didn't work.

[goodmorninggoaway]

I didn't update the default decorators to use this. You have to use it in a custom decorator.

Example:

const PoolContainer = ({ onClick, onClickIcon, node }) => {
    const hasChildren = node.children && node.children.length;

    return (
        <div className={cx('node')}>
            <Caret
                onClick={hasChildren ? onClickIcon : null}
                toggled={node.toggled}
                className={cx('caret', { invisible: !hasChildren })}
            />
            <PoolNodeIcon onClick={onClick} />
            <PoolNodeHeader node={node} onClick={onClick} />
        </div>
    );
};

I'm using this in a dropdown, and I want it to auto-close when i select a node, but not when I click the caret to explode the tree node.

[witalobenicio]

I'm using like this:

<Treebeard
                                                    onClickIcon={this.onClickIcon.bind(this)}
                                                    data={this.state.dataSecondarySubject}
                                                    style={treeStyle}
                                                    onToggle={this.onToggleSecondary.bind(this)}
                                                />

[goodmorninggoaway]

If you have no custom decorators, nothing is using it. I didn't want to break existing functionality.

…

On Wed, Feb 1, 2017 at 12:13 PM Witalo Benicio ***@***.***> wrote: I'm using like this: <Treebeard onClickIcon={this.onClickIcon.bind(this)} data={this.state.dataSecondarySubject} style={treeStyle} onToggle={this.onToggleSecondary.bind(this)} /> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#51 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFUWt1Rc7jkDuF56d2Q3MRWzVWSJ263fks5rYL0sgaJpZM4LLCZn> .

[a-siewe]

can someone merge this PR?
Please !

[kazazor]

@goodmorninggoaway - why not change the default decorators? This is just adding functionality isn't it? How will it break the existing one?

I would also expect a change in the README file saying you can pass this new prop..

[mpeula-pe]

can someone merge this PR?
It would be a very nice feature!

[MichaelDeBoey]

@mpeula-pe: @goodmorninggoaway First needs to resolve the conflicts before this one can be merged

[coveralls]

Coverage decreased (-0.9%) to 97.609% when pulling c7cc772 on goodmorninggoaway:on-click-toggle into 438c4f5 on alexcurtis:master.

[coveralls]

Coverage increased (+0.04%) to 98.594% when pulling df4550b on goodmorninggoaway:on-click-toggle into 438c4f5 on alexcurtis:master.

[Lukejkw]

When will this be merged in and available?

[mwilc0x]

This looks good to add? I also have a use case in a real world app for this functionality. Cheers!

[coveralls]

Coverage increased (+0.04%) to 98.594% when pulling dce089a on goodmorninggoaway:on-click-toggle into 438c4f5 on alexcurtis:master.

[cdtinney]

Would love to see this merged in.

[buptlee]

When will this be merged in and available?