Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Refactor panel #15

Merged
merged 6 commits into from
Sep 7, 2016
Merged

Refactor panel #15

merged 6 commits into from
Sep 7, 2016

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Sep 7, 2016

Refactored the whole codebase and make it easy to add more knobs in the future.
When we are adding a new knob, we simply need to add a story side API with single React component with how to handle it.

Also remove the ACE and simply use an autoexpanding Textarea for that.

@arunoda
Copy link
Contributor Author

arunoda commented Sep 7, 2016

@roonyh Hey look at this codebase.

@arunoda
Copy link
Contributor Author

arunoda commented Sep 7, 2016

@roonyh

I think this has some lint issues. Could you fix them?
And write some tests the Panel and for the main index.js.

Basically we need to test how these reacts when getting events from the channel and firing events to the channel. Use enzyme.

@arunoda arunoda merged commit 41d8d82 into master Sep 7, 2016
@arunoda arunoda deleted the refactor-panel branch September 7, 2016 19:29
@roonyh
Copy link
Contributor

roonyh commented Sep 8, 2016

@arunoda Looks good. A small fix is in #16. Lint fixes and tests for Panel is in #17.

Working on testing functions from main index.js.

@roonyh
Copy link
Contributor

roonyh commented Sep 8, 2016

@arunoda had to refactor the code from index.js somewhat to make it easy to test. see the commit 9961394

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants