Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figma designs not clearing when changing between stories #14

Closed
rkara opened this issue Jul 1, 2019 · 2 comments · Fixed by #15
Closed

Figma designs not clearing when changing between stories #14

rkara opened this issue Jul 1, 2019 · 2 comments · Fixed by #15
Labels
category: bug Something isn't working good first issue Good for newcomers

Comments

@rkara
Copy link

rkara commented Jul 1, 2019

Storybook for Angular
Version of storybook-addon-designs: 5.1.0

Setup:

  • Have two stories
  • Only one of the two stories has a design of type figma

Steps to reproduce within storybook

  1. Navigate to story that has figma design and select "design" add-on tab to view design.
  2. Navigate to story that does not have a design.
  3. Notice that design from first story is still visible on the "design" add-on tab.
@pocka pocka added category: bug Something isn't working good first issue Good for newcomers labels Jul 4, 2019
@pocka pocka mentioned this issue Jul 6, 2019
Merged
@pocka pocka closed this as completed in #15 Jul 6, 2019
@pocka
Copy link
Collaborator

pocka commented Jul 6, 2019

@rkara
Thank you for reporting!

Fixed in v5.1.1

@rkara
Copy link
Author

rkara commented Jul 9, 2019

@pocka
No problem! Thank you for the fast turnaround on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not persist design panel on story changes storybookjs/addon-designs
2 participants
@rkara @pocka