Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not persist design panel on story changes #15

Merged
merged 1 commit into from
Jul 6, 2019

Conversation

pocka
Copy link
Collaborator

@pocka pocka commented Jul 6, 2019

Fix bug that panel content does not update at all when changing to the story which does not have withDeisgns decorator nor design parameters.

Fix #14

Tests in live example: https://storybook-addon-designs-git-fix-addon-panel-persist.pocka.now.sh/?path=/story/tests-issues-14--do-not-persist-addon-panel-step-1

* Fix bug that panel content does not update at all when changing
  to the story which does not have `withDeisgns` decorator nor `design`
  parameters.
@pocka pocka added the category: bug Something isn't working label Jul 6, 2019
@pocka pocka self-assigned this Jul 6, 2019
@vercel
Copy link

vercel bot commented Jul 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://storybook-addon-designs-git-fix-addon-panel-persist.pocka.now.sh

@pocka pocka merged commit 256a2c0 into master Jul 6, 2019
@pocka pocka deleted the fix/addon-panel-persist branch July 6, 2019 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figma designs not clearing when changing between stories
1 participant