Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Link type #31

Closed
Romanchuk opened this issue Jan 30, 2020 · 1 comment · Fixed by #32
Closed

[Feature request] Link type #31

Romanchuk opened this issue Jan 30, 2020 · 1 comment · Fixed by #32
Labels
category: feature New feature or request

Comments

@Romanchuk
Copy link

Hello! First of all thank you for this addon, it's awesome!

Some websites can't be embeded as iframe (Cloud Confluence, notion.so) because of:

content-security-policy: frame-ancestors 'self'

And you can't change headers to fix it. There is option to proxy, but it's too challenging (mostly because of Auth).

There is an idea to add link type, that would open design link in a new tab.
@pocka pocka added the category: feature New feature or request label Jan 30, 2020
pocka added a commit that referenced this issue Feb 1, 2020
@pocka
feat: Add "link" type
8893c85 
#31
@pocka pocka mentioned this issue Feb 1, 2020
Merged
@pocka pocka closed this as completed in #32 Feb 1, 2020
@pocka
Copy link
Collaborator

pocka commented Feb 1, 2020

Implemented in v5.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "link" type storybookjs/addon-designs
2 participants
@Romanchuk @pocka