-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mulitple design tabs? #7
Labels
category: feature
New feature or request
Comments
@cgatian I believe this isn't so hard to implement. .add('foo', () => <Foo/>, {
design: [
{ type: 'figma', url: 'figma-file-1' },
{ type: 'pdf', url: 'my-pdf' },
// Tab(Select box) name might be needed
{ type: 'figma', url: 'figma-file-2', name: 'My Another Figma File' }
]
})
// Also accepts current object style parameter for backwards compatibility
.add('bar', () => <Bar/> {
design: {
type: 'figma',
url: 'figma-url'
}
}) |
Yes!
…On Wed, May 8, 2019, 6:36 AM Shota Fuji ***@***.***> wrote:
@cgatian <https://github.com/cgatian>
Yes, it sounds great!
I believe this isn't so hard to implement.
Would API be something like this?
.add('foo', () => <Foo/>, {
design: [
{ type: 'figma', url: 'figma-file-1' },
{ type: 'pdf', url: 'my-pdf' },
// Tab(Select box) name might be needed
{ type: 'figma', url: 'figma-file-2', name: 'My Another Figma File' }
]
})// Also accepts current object style parameter for backwards compatibility
.add('bar', () => <Bar/> {
design: {
type: 'figma',
url: 'figma-url'
}
})
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLY2TZT3WX2FK2CLNHDWTPUKUKRANCNFSM4HKAUWVA>
.
|
Merged
Implemented in v5.1.0 (Preview) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Perhaps you have a PDF and Figma attached to a story. It would be cool to allow multiple Design tabs for each type.
The text was updated successfully, but these errors were encountered: