Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mulitple design tabs? #7

Closed
cgatian opened this issue May 2, 2019 · 3 comments · Fixed by #9
Closed

Mulitple design tabs? #7

cgatian opened this issue May 2, 2019 · 3 comments · Fixed by #9
Labels
category: feature New feature or request

Comments

@cgatian
Copy link

cgatian commented May 2, 2019

Perhaps you have a PDF and Figma attached to a story. It would be cool to allow multiple Design tabs for each type.

@cgatian cgatian changed the title Mulitple named tabs? Mulitple design tabs? May 2, 2019
@pocka pocka added the category: feature New feature or request label May 8, 2019
@pocka
Copy link
Collaborator

pocka commented May 8, 2019

@cgatian
Yes, it sounds great!

I believe this isn't so hard to implement.
Would API be something like this?

.add('foo', () => <Foo/>, {
  design: [
    { type: 'figma', url: 'figma-file-1' },
    { type: 'pdf', url: 'my-pdf' },
    // Tab(Select box) name might be needed
    { type: 'figma', url: 'figma-file-2', name: 'My Another Figma File' }
  ]
})
// Also accepts current object style parameter for backwards compatibility
.add('bar', () => <Bar/> {
  design: {
    type: 'figma',
    url: 'figma-url'
  }
})

@cgatian
Copy link
Author

cgatian commented May 8, 2019 via email

@pocka pocka mentioned this issue May 12, 2019
@pocka pocka closed this as completed in #9 May 12, 2019
@pocka
Copy link
Collaborator

pocka commented May 12, 2019

Implemented in v5.1.0 (Preview)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants