This repository has been archived by the owner on Jul 12, 2021. It is now read-only.
Add build support for both cjs and esm #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Jun 4, 2021
IanVS
reviewed
Jun 4, 2021
package.json
Outdated
| "buildTsc": "tsc --declaration --emitDeclarationOnly --outDir ./dist", | ||
| "build": "concurrently \"yarn run buildBabel\" \"yarn run buildTsc\"", | ||
| "build:watch": "concurrently \"yarn run buildBabel -- --watch\" \"yarn run buildTsc -- --watch\"", | ||
| "buildBabel": "concurrently \"yarn buildBabel:cjs\" \"yarn buildBabel:esm\" \"yarn buildTsc\"", |
There was a problem hiding this comment.
It doesn't seem like buildTsc belongs in buildBabel, does it? I think that's handled by build below.
|
@IanVS the main and module paths were incorrect in the last build. Could you give another go with |
|
@winkerVSbecks I'm not seeing any errors from the addon, so it seems like it's doing the right thing now! (My vite builder still isn't actually building my stories correctly, but the error from this plugin is gone at least, and I now have other problems). |
|
Perfect, thank you for your help |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did?
dist/typesindex.jsfile similar to SB monorepocloses #6
📦 Published PR as canary version:
1.2.1--canary.8.cce715f.0✨ Test out this PR locally via:
npm install @storybook/addon-measure@1.2.1--canary.8.cce715f.0 # or yarn add @storybook/addon-measure@1.2.1--canary.8.cce715f.0