Dependency Version Update (react-docgen)

[ethancrook99]

What would it take to update the react-docgen dependency to 5.3.0? Related to this issue, prop tables are still missing props for components that use optional chaining. I tried to update it myself, but I found that all the tests started to fail when I updated to 5.3.0 and I couldn't identify what change made that happen.

[shilman]

The dependency is:

react-docgen": "^5.0.0"

So I think 5.3.0 matches that version spec and there are no changes required in the library, only in your project. No?

[idbartosz]

I think it still requires an update on your end

babel-plugin-react-docgen/yarn.lock

Lines 3580 to 3583 in c02946e

	react-docgen@^5.0.0:
	version "5.0.0"
	resolved "https://registry.yarnpkg.com/react-docgen/-/react-docgen-5.0.0.tgz#2a1fd50b32fc9ef4e04970e0b3ebc0387c319fea"
	integrity sha512-fToU6m0Cvx+L937lfx453/6RNUuxAq2BMop17c8juUJIwKZey3L5M2ZojawgMVnZYkJDBs0hVfHU9W7CaDUNGg==

[ethancrook99]

My bad--react-docgen might not need to be updated. One that I think actually does need to be updated is recast@0.14.7, which is now recast@0.20.3. The old version of recast has a dependency on the old version of ast-types, but the new version of recast changes some of the testing functionality for this project. It looks like getting rid of recast entirely and adding a dependency to the newest version of ast-types fixes the outdated dependency without breaking anything. I made a PR (#92) for what I think will take care of that (if it's needed)--hopefully that will explain it better. I can make a separate issue for that if more discussion/information is needed.

[shilman]

@idbartosz I don't think the lock file has any bearing on what gets installed when you add this package, only when you develop this package. Correct me if I'm wrong.

@ethancrook99 thanks for the PR! I'll take a look now!

[mpcarolin]

We also encountered this issue and would appreciate a fix (it looks like @ethancrook99 's PR handles that).

A temporary workaround for us is to use this resolution in our application's package.json:

  "resolutions": {
    "ast-types": "^0.14.0"
  },

[IanVS]

It looks like this issue can be closed, feel free to speak up if you think there's still something to do here.