Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing peer deps #500

Merged
merged 4 commits into from Sep 28, 2022

Conversation

adalinesimonian
Copy link
Contributor

Resolves missing peer dependency errors when using Yarn PnP, e.g.

ERR! Error: @storybook/builder-vite requires @vitejs/plugin-vue to be installed when using @storybook/vue or @storybook/vue3.  Please install it and start storybook again.

@IanVS
Copy link
Member

IanVS commented Sep 23, 2022

Thanks for the PR, @adalinesimonian. It looks like the yarn.lock needs to be updated, mind pushing that up?

@IanVS
Copy link
Member

IanVS commented Sep 23, 2022

Will peerDependenciesMeta keep all package managers from erroring or installing the dep if it's missing?

@adalinesimonian
Copy link
Contributor Author

Thanks for the PR, @adalinesimonian. It looks like the yarn.lock needs to be updated, mind pushing that up?

Whoops, I'll get that fixed.

Will peerDependenciesMeta keep all package managers from erroring or installing the dep if it's missing?

afaik all three major package managers support the key:

@IanVS
Copy link
Member

IanVS commented Sep 27, 2022

Thanks again for this. We're in the middle of a re-organization of the monorepo in #502. I'd like to hold off on this PR until that's done and the dust settles. It should be soon, and we'll be sure to get the peer deps taken care of before the next release.

@IanVS IanVS force-pushed the adalinesimonian/add-peer-deps branch 2 times, most recently from e7c25e6 to 3b886e7 Compare September 28, 2022 02:16
@IanVS IanVS force-pushed the adalinesimonian/add-peer-deps branch from 3b886e7 to 31e83ba Compare September 28, 2022 02:20
@IanVS IanVS merged commit 5b729ac into storybookjs:main Sep 28, 2022
@adalinesimonian adalinesimonian deleted the adalinesimonian/add-peer-deps branch October 14, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants