Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of version prop for Search #24

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Conversation

kylegach
Copy link
Collaborator

@kylegach kylegach commented Sep 1, 2022

  • Passing a number means 7.0 is condensed to 7, when Algolia expects "7.0"
πŸ“¦ Published PR as canary version: 2.0.10--canary.24.de4d51f.0

✨ Test out this PR locally via:

npm install @storybook/components-marketing@2.0.10--canary.24.de4d51f.0
# or 
yarn add @storybook/components-marketing@2.0.10--canary.24.de4d51f.0

- Passing a number means `7.0` is condensed to `7`, when Algolia expects "7.0"
Copy link
Collaborator

@winkerVSbecks winkerVSbecks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ™πŸ½ much appreciated

@winkerVSbecks winkerVSbecks merged commit e2c572a into main Sep 1, 2022
@winkerVSbecks winkerVSbecks deleted the fix-search-version-type branch September 1, 2022 20:52
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

πŸš€ PR was released in v2.0.10 πŸš€

@github-actions github-actions bot added the released This issue/pull request has been released. label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants