Nav and related components #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winkerVSbecks
force-pushed
the
nav-components
branch
from
4714e36
to
13e039e
Compare
* Menu button * Collapsed nav * Drawer * NavItem * NavMenu * StackedNav
winkerVSbecks
force-pushed
the
nav-components
branch
from
13e039e
to
cda141f
Compare
winkerVSbecks
requested review from
chantastic,
kylegach,
jonniebigodes and
domyen
chantastic
approved these changes
Jul 11, 2022
|
@chantastic nothing specific but it's a lot of code so wanted to run it by someone else. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the menu component is a placeholder. I'll implement the toggle functionality with the sub-nav component.
Design spec: https://www.figma.com/file/ur4kydUbRqdDyfoZWzdiIw/Storybook-app?node-id=1836:55194
📦 Published PR as canary version:
0.1.1-canary.5.a7cc709.0✨ Test out this PR locally via:
npm install @storybook/components-marketing@0.1.1-canary.5.a7cc709.0 # or yarn add @storybook/components-marketing@0.1.1-canary.5.a7cc709.0