Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe values for doc search facets #59

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented Jan 12, 2023

📦 Published PR as canary version: 2.0.43--canary.59.e71de9c.0

✨ Test out this PR locally via:

npm install @storybook/components-marketing@2.0.43--canary.59.e71de9c.0
# or 
yarn add @storybook/components-marketing@2.0.43--canary.59.e71de9c.0

along with docs. Values inside an array act as an OR
between the containing values
*/
[`tags:docs`, `tags:recipes`],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker: I wonder if we want to refactor this to use tags:agnostic (or some other term, tags:searchable, maybe?), so that we don't need to continue updating this whenever we make a new content type searchable?

Copy link
Collaborator

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve, as this is shippable as-is. But I left a comment to consider.

@ShaunEvening ShaunEvening merged commit 24f7229 into main Jan 12, 2023
@github-actions
Copy link

🚀 PR was released in v2.0.43 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants