-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe values for doc search facets #59
Conversation
along with docs. Values inside an array act as an OR | ||
between the containing values | ||
*/ | ||
[`tags:docs`, `tags:recipes`], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker: I wonder if we want to refactor this to use tags:agnostic
(or some other term, tags:searchable
, maybe?), so that we don't need to continue updating this whenever we make a new content type searchable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve, as this is shippable as-is. But I left a comment to consider.
🚀 PR was released in |
📦 Published PR as canary version:
2.0.43--canary.59.e71de9c.0
✨ Test out this PR locally via:
npm install @storybook/components-marketing@2.0.43--canary.59.e71de9c.0 # or yarn add @storybook/components-marketing@2.0.43--canary.59.e71de9c.0