Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Change build scripts to use tsup instead of tsc #26

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Apr 25, 2023

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major
πŸ“¦ Published PR as canary version: 0.1.1--canary.26.df816e6.0

✨ Test out this PR locally via:

npm install @storybook/jest@0.1.1--canary.26.df816e6.0
# or 
yarn add @storybook/jest@0.1.1--canary.26.df816e6.0

Version

Published prerelease version: v0.1.1-future.2

Changelog

πŸŽ‰ This release contains work from a new contributor! πŸŽ‰

Thank you, Norbert de Langen (@ndelangen), for all your work!

πŸ› Bug Fix

⚠️ Pushed to future

  • Merge branch 'main' into future [skip-ci] (@yannbf)
  • update dependencies to future (@yannbf)

πŸ“ Documentation

  • Add more explanation to the types FAQ #25 (@yannbf)

Authors: 2

@ndelangen ndelangen self-assigned this Apr 25, 2023
@ndelangen ndelangen requested a review from yannbf April 25, 2023 14:37
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub β†—οΈŽ


🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore esbuild@0.14.54
  • @SocketSecurity ignore mz@2.7.0
  • @SocketSecurity ignore rollup@2.79.1
  • @SocketSecurity ignore tree-kill@1.2.2
  • @SocketSecurity ignore load-tsconfig@0.2.5
  • @SocketSecurity ignore tsup@5.12.9
  • @SocketSecurity ignore source-map@0.8.0-beta.0
πŸ“œ Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
esbuild@0.14.54 (added) postinstall package.json via tsup@5.12.9
⚠️ Shell access

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Package Module Location Source
esbuild@0.14.54 (added) child_process install.js package.json via tsup@5.12.9
esbuild@0.14.54 (added) child_process lib/main.js package.json via tsup@5.12.9
mz@2.7.0 (added) child_process child_process.js package.json via tsup@5.12.9
rollup@2.79.1 (added) child_process dist/shared/watch-cli.js package.json via tsup@5.12.9
tree-kill@1.2.2 (added) child_process index.js package.json via tsup@5.12.9
⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
load-tsconfig@0.2.5 (added) Function dist/index.cjs package.json via tsup@5.12.9
load-tsconfig@0.2.5 (added) Function dist/index.js package.json via tsup@5.12.9
rollup@2.79.1 (added) Function dist/shared/loadConfigFile.js package.json via tsup@5.12.9
rollup@2.79.1 (added) Function dist/shared/loadConfigFile.js package.json via tsup@5.12.9
tsup@5.12.9 (added) Function dist/chunk-Q2NKY6R2.js package.json
tsup@5.12.9 (added) Function dist/rollup.js package.json
⚠️ New author

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Package New Author Previous Author Source
source-map@0.8.0-beta.0 (added) loganfsmyth nickfitzgerald package.json via tsup@5.12.9
Pull request alert summary
Issue Status
Install scripts ⚠️ 1 issue
Native code βœ… 0 issues
Bin script confusion βœ… 0 issues
Bin script shell injection βœ… 0 issues
Shell access ⚠️ 5 issues
Uses eval ⚠️ 6 issues
Unresolved require βœ… 0 issues
Invalid package.json βœ… 0 issues
HTTP dependency βœ… 0 issues
Git dependency βœ… 0 issues
GitHub dependency βœ… 0 issues
New author ⚠️ 1 issue
Potential typo squat βœ… 0 issues
Known Malware βœ… 0 issues
Telemetry βœ… 0 issues
Protestware/Troll package βœ… 0 issues

πŸ“Š Modified Dependency Overview:

βž• Added Package Capability Access +/- Transitive Count Publisher
tsup@5.12.9 eval, network, filesystem, environment +45 egoist
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
typescript@5.0.4 4.9.5...5.0.4 None +0/-0 typescript-bot

package.json Outdated Show resolved Hide resolved
@yannbf yannbf added the patch Increment the patch version when merged label Apr 26, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this :))

@yannbf yannbf changed the title change to use tsup Change build scripts to use tsup instead of tsc Apr 26, 2023
@yannbf yannbf merged commit 2dc815b into future Apr 26, 2023
3 of 4 checks passed
@yannbf yannbf deleted the norbert/tsup branch April 26, 2023 11:53
@github-actions github-actions bot added the prerelease This change is available in a prerelease. label Apr 26, 2023
ndelangen added a commit to storybookjs/testing-library that referenced this pull request Apr 28, 2023
This was referenced Jun 19, 2023
@yannbf yannbf mentioned this pull request Aug 17, 2023
5 tasks
@github-actions
Copy link

πŸš€ PR was released in v0.2.0 πŸš€

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants