Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering html tag in markdown (components mode) #36

Merged
merged 2 commits into from
Jan 6, 2018
Merged

Fix rendering html tag in markdown (components mode) #36

merged 2 commits into from
Jan 6, 2018

Conversation

sjstyle
Copy link
Contributor

@sjstyle sjstyle commented Aug 14, 2017

Source Markdown

(I add one space on end of javascript code block(const clause) because without space it rendered as valid code block, so breaks rendering result)

# Some blog title

Just need to show you some code first:

```js
const foo = "bar"
`` `

<font color="red"> this is root red text </font>

* list 1
* list 2
* <font color="blue">list blue text</font>
* list 3
   * <font color="green">two depth green text</font>


<Row>
  <Col>Need to tell you something over here</Col>
  <Col>And over here</Col>
</Row>

Before this pr

image

After this pr

image

@sjstyle sjstyle changed the title Fix html render Fix rendering html tag in markdown Aug 14, 2017
@christianalfoni
Copy link
Collaborator

@sjstyle Hi there and so sorry for my late reply! I have been in paternity leave and just got back to work with way too much to do :)

A couple of comments:

  1. The package.json entry has to be lib/index.js... or else it will load up babel-transpiler, the components thing is opt-in

  2. Would you mind writing a test to ensure this works? :)

If not I will look into this later!

@ndelangen
Copy link
Member

@sjstyle Would you be interested in resolving the conflicts for us?

I think this we can get this merged!

@ndelangen ndelangen added the bug label Jan 5, 2018
@sjstyle
Copy link
Contributor Author

sjstyle commented Jan 6, 2018

@christianalfoni @ndelangen
Sorry for late. I just rebased and add test for this PR.

@ndelangen ndelangen merged commit a77300c into storybookjs:master Jan 6, 2018
@ndelangen
Copy link
Member

♥️ We should release this asap @Hypnosphi

@Hypnosphi
Copy link
Member

Released as 6.0.3

@Hypnosphi
Copy link
Member

@sjstyle can you please fix it for default mode (src/index.js) as well?

@Hypnosphi Hypnosphi changed the title Fix rendering html tag in markdown Fix rendering html tag in markdown (components mode) Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants