Make elements.code and elements.codespan options work as documented
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
changed the title
elements.code and elements.codespan options work as documented
|
@christianalfoni thanks for opening the doors for us to fix this. If you can merge this and publish a new version for us, it'd be much appreciated! |
This was referenced Nov 21, 2017
|
Currently running into issues in Spectacle related to this bug. |
|
Included in #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #38
Current behaviour:
— block code rendering can be overriden only in "components" mode
— inline code is rendered by
elements.codenotelement.codespanDesired (and documented) behaviour:
— block code rendering can be overriden with
elements.code({language, code})— inline code rendering can be overriden with
elements.codespan({children})