Change default iOS device to iPhone 12 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of this PR: #69, I'd like to set the default iOS emulator device to the iPhone 12 because my storybook iOS components are compatible with iOS 14+. The iPhone 12's are the only devices on the device list that default to iOS 14.
Since there isn't really a way to switch emulator OS versions right now, having the emulator default to an iPhone 12 would be much more convenient to users viewing mobile components that support the latest iOS versions (instead of having to instruct them to switch devices using the device menu each time they view a new component).
📦 Published PR as canary version:
2.2.4-canary.70.754.0✨ Test out this PR locally via:
npm install @storybook/native-android-material-deep-link-example@2.2.4-canary.70.754.0 npm install @storybook/native-controls-example@2.2.4-canary.70.754.0 npm install @storybook/native-cross-platform-example@2.2.4-canary.70.754.0 npm install @storybook/native-flutter-example@2.2.4-canary.70.754.0 npm install @storybook/native-ios-example-deep-link@2.2.4-canary.70.754.0 npm install @storybook/native-addon@2.2.4-canary.70.754.0 npm install @storybook/native-controllers@2.2.4-canary.70.754.0 npm install @storybook/deep-link-logger@2.2.4-canary.70.754.0 npm install @storybook/native-dev-middleware@2.2.4-canary.70.754.0 npm install @storybook/native-devices@2.2.4-canary.70.754.0 npm install @storybook/native-components@2.2.4-canary.70.754.0 npm install @storybook/native@2.2.4-canary.70.754.0 npm install @storybook/native-types@2.2.4-canary.70.754.0 # or yarn add @storybook/native-android-material-deep-link-example@2.2.4-canary.70.754.0 yarn add @storybook/native-controls-example@2.2.4-canary.70.754.0 yarn add @storybook/native-cross-platform-example@2.2.4-canary.70.754.0 yarn add @storybook/native-flutter-example@2.2.4-canary.70.754.0 yarn add @storybook/native-ios-example-deep-link@2.2.4-canary.70.754.0 yarn add @storybook/native-addon@2.2.4-canary.70.754.0 yarn add @storybook/native-controllers@2.2.4-canary.70.754.0 yarn add @storybook/deep-link-logger@2.2.4-canary.70.754.0 yarn add @storybook/native-dev-middleware@2.2.4-canary.70.754.0 yarn add @storybook/native-devices@2.2.4-canary.70.754.0 yarn add @storybook/native-components@2.2.4-canary.70.754.0 yarn add @storybook/native@2.2.4-canary.70.754.0 yarn add @storybook/native-types@2.2.4-canary.70.754.0