-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prepareStories to handle more options & strip play functions #573
Conversation
I'd like to make an adjustment to enable the play fn via an option in the config but this looks good to me. |
@dannyhw is it actually possible to execute the play fn on native? If so, I definitely see how the option would be useful (and would also be interested myself in how to enable play fn support). I imagine there must be some significant work in terms of getting |
@awinograd the play function gets called and you can run javascript in there, we just haven't got a way to query elements at runtime without a tool like detox. The idea is that later we could find a way to make it work, I just don't want to change behaviour right now in a minor version even if it doesn't really do much. I can make the adjustment it will probably just look like this in your main.js
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awinograd I pushed some changed the pr that adds some options to main.ts that can be expanded on later. Also probably we don't need the other pr since this one has both sets of changes right? Let me know if you're ok with these changes.
@dannyhw the new option looks ok to me! I've closed the other PR since you are right that this one includes that functionality. Thanks for taking a look at this PR! |
Issue:
What I did
Adds tests for #570 and adds support for includeStories/excludeStories CSF options on meta.
How to test
Please explain how to test your changes and consider the following questions
Unit tests have been added to cover new/changed functionality
If your answer is yes to any of these, please make sure to include it in your PR.