Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

build: set up codeql analysis #95

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Conversation

jimmyandrade
Copy link
Contributor

This PR proposes adding CodeQL Analysis

@jimmyandrade jimmyandrade self-assigned this Oct 6, 2020
Copy link
Contributor Author

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review)

Copy link
Contributor

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 cc @gaetanmaisse

matrix:
# Override automatic language detection by changing the below list
# Supported options are ['csharp', 'cpp', 'go', 'java', 'javascript', 'python']
language: ['javascript']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typescript?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you suggesting adding typescript?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good try @shilman but this repo only contains JS, plus:

Supported options are ['csharp', 'cpp', 'go', 'java', 'javascript', 'python']

I knew it! Deep down you're a TS fanboy. 😛 😂

matrix:
# Override automatic language detection by changing the below list
# Supported options are ['csharp', 'cpp', 'go', 'java', 'javascript', 'python']
language: ['javascript']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good try @shilman but this repo only contains JS, plus:

Supported options are ['csharp', 'cpp', 'go', 'java', 'javascript', 'python']

I knew it! Deep down you're a TS fanboy. 😛 😂

@jimmyandrade jimmyandrade merged commit e704081 into master Nov 6, 2020
@jimmyandrade jimmyandrade deleted the build/add-codeql-analysis branch November 6, 2020 17:46
@hipstersmoothie
Copy link
Contributor

🚀 PR was released in v2.8.8 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released This issue/pull request has been released. security
Development

Successfully merging this pull request may close these issues.

None yet

5 participants