Skip to content

Commit

Permalink
Change /dist to ESM && upgrade required dependencies to make this hap…
Browse files Browse the repository at this point in the history
…pen & deal with the consequences
  • Loading branch information
ndelangen committed Nov 26, 2020
1 parent 046035a commit 04acc44
Show file tree
Hide file tree
Showing 201 changed files with 4,703 additions and 7,054 deletions.
44 changes: 41 additions & 3 deletions .babelrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,24 @@ const withTests = {
],
};

const modules = process.env.BABEL_ESM === 'true' ? false : 'auto';

module.exports = {
ignore: [
'./lib/codemod/src/transforms/__testfixtures__',
'./lib/postinstall/src/__testfixtures__',
],
presets: [
['@babel/preset-env', { shippedProposals: true, useBuiltIns: 'usage', corejs: '3' }],
[
'@babel/preset-env',
{
shippedProposals: true,
useBuiltIns: 'usage',
corejs: '3',
targets: 'defaults',
modules,
},
],
'@babel/preset-typescript',
'@babel/preset-react',
'@babel/preset-flow',
Expand Down Expand Up @@ -52,7 +63,16 @@ module.exports = {
{
test: './lib',
presets: [
['@babel/preset-env', { shippedProposals: true, useBuiltIns: 'usage', corejs: '3' }],
[
'@babel/preset-env',
{
shippedProposals: true,
useBuiltIns: 'usage',
corejs: '3',
modules,
targets: 'defaults',
},
],
'@babel/preset-react',
],
plugins: [
Expand Down Expand Up @@ -83,8 +103,9 @@ module.exports = {
shippedProposals: true,
useBuiltIns: 'usage',
targets: {
node: '8.11',
node: '10',
},
modules,
corejs: '3',
},
],
Expand All @@ -104,5 +125,22 @@ module.exports = {
test: withTests,
},
},
{
test: ['**/virtualModuleEntry.template.js'],
presets: [
[
'@babel/preset-env',
{
shippedProposals: true,
useBuiltIns: 'usage',
targets: {
node: '10',
},
corejs: '3',
modules: false,
},
],
],
},
],
};
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ module.exports = {
{
files: ['**/*.tsx', '**/*.ts'],
rules: {
'react/require-default-props': 'off',
'react/prop-types': 'off', // we should use types
'no-dupe-class-members': 'off', // this is called overloads in typescript
},
Expand Down
3 changes: 2 additions & 1 deletion addons/a11y/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"directory": "addons/a11y"
},
"license": "MIT",
"main": "dist/index.js",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
"types": "dist/index.d.ts",
"typesVersions": {
"<3.8": {
Expand Down
14 changes: 13 additions & 1 deletion addons/a11y/preset.js
Original file line number Diff line number Diff line change
@@ -1 +1,13 @@
module.exports = require('./dist/preset');
function managerEntries(entry = []) {
return [...entry, require.resolve('./dist/esm/register')];
}

function config(entry = []) {
return [
...entry,
require.resolve('./dist/esm/a11yRunner'),
require.resolve('./dist/esm/a11yHighlight'),
];
}

module.exports = { managerEntries, config };
2 changes: 1 addition & 1 deletion addons/a11y/register.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
require('./dist/register');
require('./dist/esm/register');
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { withA11y } from '../index';
import { withA11y } from '.';

export const decorators = [withA11y];
4 changes: 2 additions & 2 deletions addons/a11y/src/components/Report/Rules.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ const Rule: FunctionComponent<RuleProps> = ({ rule }) => {
}
return (
<SizeMe refreshMode="debounce">
{({ size }: { size: { width: number; height: number } }) => (
<Item elementWidth={size.width}>
{({ size }) => (
<Item elementWidth={size.width || 0}>
<StyledBadge status={badgeType}>{formatSeverityText(rule.impact)}</StyledBadge>
<Message>{rule.message}</Message>
</Item>
Expand Down
4 changes: 2 additions & 2 deletions addons/a11y/src/components/Tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export const Tabs: React.FC<TabsProps> = ({ tabs }) => {
const highlightLabel = `Highlight results`;
return (
<SizeMe refreshMode="debounce">
{({ size }: { size: any }) => (
{({ size }) => (
<Container>
<List>
<TabsWrapper>
Expand All @@ -130,7 +130,7 @@ export const Tabs: React.FC<TabsProps> = ({ tabs }) => {
</TabsWrapper>
</List>
{tabs[activeTab].items.length > 0 ? (
<GlobalToggle elementWidth={size.width}>
<GlobalToggle elementWidth={size.width || 0}>
<HighlightToggleLabel htmlFor={highlightToggleId}>
{highlightLabel}
</HighlightToggleLabel>
Expand Down
7 changes: 0 additions & 7 deletions addons/a11y/src/preset/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion addons/a11y/src/typings.d.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
declare module 'global';
declare module 'react-sizeme';
6 changes: 3 additions & 3 deletions addons/actions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"directory": "addons/actions"
},
"license": "MIT",
"main": "dist/index.js",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
"types": "dist/index.d.ts",
"typesVersions": {
"<3.8": {
Expand Down Expand Up @@ -51,11 +52,10 @@
"regenerator-runtime": "^0.13.7",
"ts-dedent": "^2.0.0",
"util-deprecate": "^1.0.2",
"uuid": "^8.0.0"
"uuid-browser": "^3.1.0"
},
"devDependencies": {
"@types/lodash": "^4.14.150",
"@types/uuid": "^7.0.3",
"@types/webpack-env": "^1.15.3"
},
"peerDependencies": {
Expand Down
17 changes: 16 additions & 1 deletion addons/actions/preset.js
Original file line number Diff line number Diff line change
@@ -1 +1,16 @@
module.exports = require('./dist/preset');
function managerEntries(entry, options) {
return [...entry, require.resolve('./dist/esm/register')];
}

function config(entry = [], { addDecorator = true } = {}) {
const actionConfig = [];
if (addDecorator) {
actionConfig.push(require.resolve('./dist/esm/preset/addDecorator'));
}
return [...entry, ...actionConfig, require.resolve('./dist/esm/preset/addArgs')];
}

module.exports = {
managerEntries,
config,
};
2 changes: 1 addition & 1 deletion addons/actions/register.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
require('./dist/register');
require('./dist/esm/register');
15 changes: 0 additions & 15 deletions addons/actions/src/preset/index.ts

This file was deleted.

2 changes: 1 addition & 1 deletion addons/actions/src/preview/action.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { v4 as uuidv4 } from 'uuid';
import uuidv4 from 'uuid-browser/v4';
import { addons } from '@storybook/addons';
import { EVENT_ID } from '../constants';
import { ActionDisplay, ActionOptions, HandlerFunction } from '../models';
Expand Down
1 change: 1 addition & 0 deletions addons/actions/src/typings.d.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// TODO: following packages need definition files or a TS migration
declare module 'global';
declare module 'react-inspector';
declare module 'uuid-browser/v4';
3 changes: 2 additions & 1 deletion addons/backgrounds/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
},
"license": "MIT",
"author": "jbaxleyiii",
"main": "dist/index.js",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
"types": "dist/index.d.ts",
"typesVersions": {
"<3.8": {
Expand Down
17 changes: 16 additions & 1 deletion addons/backgrounds/preset.js
Original file line number Diff line number Diff line change
@@ -1 +1,16 @@
module.exports = require('./dist/preset');
function config(entry = []) {
return [
...entry,
require.resolve('./dist/esm/preset/addDecorator'),
require.resolve('./dist/esm/preset/addParameter'),
];
}

function managerEntries(entry = [], options) {
return [...entry, require.resolve('./dist/esm/register')];
}

module.exports = {
managerEntries,
config,
};
2 changes: 1 addition & 1 deletion addons/backgrounds/register.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
require('./dist/register');
require('./dist/esm/register');
3 changes: 2 additions & 1 deletion addons/controls/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"directory": "addons/controls"
},
"license": "MIT",
"main": "dist/register.js",
"main": "dist/cjs/register.js",
"module": "dist/esm/register.js",
"files": [
"dist/**/*",
"README.md",
Expand Down
9 changes: 8 additions & 1 deletion addons/controls/preset.js
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
module.exports = require('./dist/preset');
const { ensureDocsBeforeControls } = require('./dist/cjs/preset/ensureDocsBeforeControls');

function managerEntries(entry = [], options) {
ensureDocsBeforeControls(options.configDir);
return [...entry, require.resolve('./dist/esm/register')];
}

module.exports = { managerEntries };
2 changes: 1 addition & 1 deletion addons/controls/register.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export * from './dist/register';
import './dist/esm/register';
6 changes: 0 additions & 6 deletions addons/controls/src/preset/index.ts

This file was deleted.

3 changes: 2 additions & 1 deletion addons/cssresources/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
},
"license": "MIT",
"author": "nm123github",
"main": "dist/index.js",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
"types": "dist/index.d.ts",
"typesVersions": {
"<3.8": {
Expand Down
5 changes: 5 additions & 0 deletions addons/cssresources/preset.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
function managerEntries(entry = [], options) {
return [...entry, require.resolve('./dist/esm/register')];
}

module.exports = { managerEntries };
2 changes: 1 addition & 1 deletion addons/cssresources/register.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
require('./dist/register.js');
require('./dist/esm/register.js');

0 comments on commit 04acc44

Please sign in to comment.