key and value for select knob match key/value of options

fixes #799
storybookjs · Jul 9, 2017 · 597827d · 597827d
1 parent fa75121
commit 597827d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/addons/knobs/src/components/types/Select.js b/addons/knobs/src/components/types/Select.js
@@ -18,18 +18,19 @@ const styles = {
 };
 
 class SelectType extends React.Component {
-  _makeOpt(key, val) {
+  _makeOpt(key, value) {
     const opts = {
       key,
-      value: key,
+      value,
     };
 
     return (
       <option {...opts}>
-        {val}
+        {key}
       </option>
     );
   }
+
   _options(values) {
     let data = [];
     if (Array.isArray(values)) {
@@ -68,6 +69,7 @@ SelectType.propTypes = {
   knob: PropTypes.shape({
     name: PropTypes.string,
     value: PropTypes.string,
+    options: PropTypes.oneOfType([PropTypes.array, PropTypes.object]),
   }),
   onChange: PropTypes.func,
 };