fix(essentials): use require.resolve to ensure Yarn PnP compatibility

`register` file of various addon should be resolve in the context of `addon-essentials` and not in the one of SB user projects
storybookjs · May 1, 2020 · 7d2dab6 · 7d2dab6
1 parent d44ff25
commit 7d2dab6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/addons/essentials/package.json b/addons/essentials/package.json
@@ -38,7 +38,8 @@
     "ts-dedent": "^1.1.1"
   },
   "devDependencies": {
-    "@types/jest": "^25.1.1"
+    "@types/jest": "^25.1.1",
+    "@types/webpack-env": "^1.15.1"
   },
   "peerDependencies": {
     "babel-loader": "^8.0.0",

diff --git a/addons/essentials/src/index.ts b/addons/essentials/src/index.ts
@@ -27,6 +27,6 @@ export function managerEntries(entry: any[] = [], options: PresetOptions = {}) {
     .filter((key) => (options as any)[key] !== false)
     .map((key) => makeAddon(key))
     .filter((addon) => !isInstalled(addon))
-    .map((addon) => `${addon}/register`);
+    .map((addon) => require.resolve(`${addon}/register`));
   return [...entry, ...registerAddons];
 }
diff --git a/addons/essentials/tsconfig.json b/addons/essentials/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "rootDir": "./src",
-    "types": ["jest"]
+    "types": ["webpack-env", "jest"]
   },
   "include": ["src/**/*"],
   "exclude": ["src/**.test.ts"]