ship it

storybookjs · Mar 8, 2024 · b4e944d · b4e944d
1 parent d0663d6
commit b4e944d
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts b/code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts
@@ -8,7 +8,7 @@ import { isCorePackage } from '@storybook/core-common';
 
 type PackageMetadata = {
   packageName: string;
-  beforeVersion: string;
+  beforeVersion: string | null;
   afterVersion: string | null;
 };
 
@@ -23,7 +23,7 @@ async function getLatestVersions(
   return Promise.all(
     packages.map(async ([packageName, beforeVersion]) => ({
       packageName,
-      beforeVersion,
+      beforeVersion: coerce(beforeVersion)?.toString() || null,
       afterVersion: await packageManager.latestVersion(packageName).catch(() => null),
     }))
   );
@@ -74,13 +74,18 @@ export const upgradeStorybookRelatedDependencies = {
     ).map((packageName) => [packageName, allDependencies[packageName]]) as [string, string][];
 
     const packageVersions = await getLatestVersions(packageManager, uniquePackages);
-    const upgradablePackages = packageVersions.filter(({ packageName, afterVersion }) => {
-      if (afterVersion === null) {
-        return false;
-      }
+    const upgradablePackages = packageVersions.filter(
+      ({ packageName, afterVersion, beforeVersion }) => {
+        if (beforeVersion === null) {
+          return false;
+        }
+        if (afterVersion === null) {
+          return false;
+        }
 
-      return isPackageUpgradable(afterVersion, packageName, allDependencies);
-    });
+        return isPackageUpgradable(afterVersion, packageName, allDependencies);
+      }
+    );
 
     return upgradablePackages.length > 0 ? { upgradable: upgradablePackages } : null;
   },