Skip to content

Commit

Permalink
Merge pull request #18714 from storybookjs/fix-commonjs-detection
Browse files Browse the repository at this point in the history
CLI: Fix detection of type: module when initializing storybook
  • Loading branch information
IanVS committed Jul 15, 2022
2 parents 7cad10b + 653a9ff commit d1673e1
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/cli/src/generators/baseGenerator.ts
Expand Up @@ -12,6 +12,7 @@ export type GeneratorOptions = {
language: SupportedLanguage;
builder: Builder;
linkable: boolean;
commonJs: boolean;
};

export interface FrameworkOptions {
Expand Down Expand Up @@ -67,7 +68,7 @@ const hasInteractiveStories = (framework: SupportedFrameworks) =>
export async function baseGenerator(
packageManager: JsPackageManager,
npmOptions: NpmOptions,
{ language, builder }: GeneratorOptions,
{ language, builder, commonJs }: GeneratorOptions,
framework: SupportedFrameworks,
options: FrameworkOptions = defaultOptions
) {
Expand Down Expand Up @@ -150,7 +151,7 @@ export async function baseGenerator(
framework: frameworkPackage,
addons: [...addons, ...stripVersions(extraAddons)],
extensions,
commonJs: options.commonJs,
commonJs,
...mainOptions,
});
if (addComponents) {
Expand Down

0 comments on commit d1673e1

Please sign in to comment.