Merge pull request #23377 from storybookjs/chaks/strict-ts-preset-vue…

…3-webpack5 Build: Migrate `preset-vue3-webpack` to ts strict mode
storybookjs · Jul 26, 2023 · e329ab1 · e329ab1
2 parents bf9b17f + 06d940b
commit e329ab1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/code/presets/vue3-webpack/src/framework-preset-vue3-docs.ts b/code/presets/vue3-webpack/src/framework-preset-vue3-docs.ts
@@ -16,15 +16,15 @@ export const webpackFinal: StorybookConfig['webpackFinal'] = (config, options) =
     }
   });
 
-  config.module.rules.push({
+  config.module?.rules?.push({
     test: /\.vue$/,
     loader: require.resolve('vue-docgen-loader', {
       paths: [require.resolve('@storybook/preset-vue3-webpack')],
     }),
     enforce: 'post',
     options: {
       docgenOptions: {
-        alias: config.resolve.alias,
+        alias: config.resolve?.alias,
         ...vueDocgenOptions,
       },
     },

diff --git a/code/presets/vue3-webpack/src/framework-preset-vue3.ts b/code/presets/vue3-webpack/src/framework-preset-vue3.ts
@@ -6,7 +6,7 @@ export const webpack: StorybookConfig['webpack'] = (config) => {
   return {
     ...config,
     plugins: [
-      ...config.plugins,
+      ...(config.plugins ?? []),
       new VueLoaderPlugin(),
       new DefinePlugin({
         __VUE_OPTIONS_API__: JSON.stringify(true),
@@ -16,7 +16,7 @@ export const webpack: StorybookConfig['webpack'] = (config) => {
     module: {
       ...config.module,
       rules: [
-        ...config.module.rules,
+        ...(config.module?.rules ?? []),
         {
           test: /\.vue$/,
           loader: require.resolve('vue-loader'),
@@ -51,9 +51,9 @@ export const webpack: StorybookConfig['webpack'] = (config) => {
     },
     resolve: {
       ...config.resolve,
-      extensions: [...config.resolve.extensions, '.vue'],
+      extensions: [...(config.resolve?.extensions ?? []), '.vue'],
       alias: {
-        ...config.resolve.alias,
+        ...config.resolve?.alias,
         vue$: require.resolve('vue/dist/vue.esm-bundler.js'),
       },
     },

diff --git a/code/presets/vue3-webpack/tsconfig.json b/code/presets/vue3-webpack/tsconfig.json
@@ -3,7 +3,7 @@
   "compilerOptions": {
     "resolveJsonModule": true,
     "skipLibCheck": true,
-    "strict": false
+    "strict": true
   },
   "include": ["src/**/*"]
 }