Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF format stories disappear after some change - Hot reloading #10030

Closed
kvedantmahajan opened this issue Mar 3, 2020 · 10 comments
Closed

CSF format stories disappear after some change - Hot reloading #10030

kvedantmahajan opened this issue Mar 3, 2020 · 10 comments

Comments

@kvedantmahajan
Copy link

kvedantmahajan commented Mar 3, 2020

I have started to migrate to CSF format stories one by one. What I realised is that I have to reload manually to see my migrated stories.

Steps to reproduce the behavior:

  1. Change the API from storiesOf API format to CSF format.
  2. Check the left side for your components
  3. Congrats, you can't see
  4. Refresh the page and you can.

System:

Environment Info:

System:
OS: macOS 10.15.2
CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
Binaries:
Node: 12.10.0 - ~/.nvm/versions/node/v12.10.0/bin/node
Yarn: 1.19.1 - /usr/local/bin/yarn
npm: 6.10.3 - ~/.nvm/versions/node/v12.10.0/bin/npm
Browsers:
Chrome: 80.0.3987.122
Safari: 13.0.4
npmPackages:
@storybook/addon-a11y: ^5.3.14 => 5.3.14
@storybook/addon-actions: ^5.3.14 => 5.3.14
@storybook/addon-console: ^1.2.1 => 1.2.1
@storybook/addon-docs: ^5.3.14 => 5.3.14
@storybook/addon-info: ^5.3.14 => 5.3.14
@storybook/addon-notes: ^5.3.14 => 5.3.14
@storybook/addon-storyshots: ^5.3.14 => 5.3.14
@storybook/addon-viewport: ^5.3.14 => 5.3.14
@storybook/react: ^5.3.14 => 5.3.14
@storybook/source-loader: ^5.3.14 => 5.3.14

@shilman
Copy link
Member

shilman commented Mar 4, 2020

cc @ndelangen @tmeasday

@stale
Copy link

stale bot commented Mar 26, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 26, 2020
@kvedantmahajan
Copy link
Author

I want this. It is clearly a bug

@stale stale bot removed the inactive label Mar 26, 2020
@shilman
Copy link
Member

shilman commented Mar 26, 2020

Do you have a repro repo?

@kvedantmahajan
Copy link
Author

kvedantmahajan commented Mar 28, 2020

Repo is open source at - https://github.com/turtlemint/mint-ui
Steps to reproduce mentioned already.

@shilman
Copy link
Member

shilman commented Mar 29, 2020

Any interest in trying to contribute a fix?

@kvedantmahajan
Copy link
Author

@tmeasday
Copy link
Member

These code paths have changed significantly in 6.0 (next). I would definitely try it with a recent alpha before investigating too much.

(Not saying the bug is necessarily fixed, but it might be!)

@stale
Copy link

stale bot commented Apr 19, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 19, 2020
@stale
Copy link

stale bot commented May 19, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants