Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.0.0-beta.25] Static build fails to load #11132

Closed
aputinski opened this issue Jun 11, 2020 · 4 comments
Closed

[v6.0.0-beta.25] Static build fails to load #11132

aputinski opened this issue Jun 11, 2020 · 4 comments
Assignees

Comments

@aputinski
Copy link

Describe the bug
Storybook works as expected when running in dev mode, but when serving the static build, the loading spinner / stencils display indefinitely and the following warning is logged:

received a SET_STORIES frame that was not configured as a ref

To Reproduce
https://github.com/aputinski/storybook-build-test-case

System:

System:
    OS: macOS 10.15.3
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
  Binaries:
    Node: 12.16.1
    Yarn: 1.22.4 
    npm: 6.13.4
  Browsers:
    Chrome: 83.0.4103.97
    Firefox: 77.0
    Safari: 13.0.5
  npmPackages:
    @storybook/addon-actions: 6.0.0-beta.25 => 6.0.0-beta.25
    @storybook/addon-docs: 6.0.0-beta.25 => 6.0.0-beta.25
    @storybook/addon-knobs: 6.0.0-beta.25 => 6.0.0-beta.25
    @storybook/addons: 6.0.0-beta.25 => 6.0.0-beta.25
    @storybook/react: 6.0.0-beta.25 => 6.0.0-beta.25
    @storybook/web-components: 6.0.0-beta.25 => 6.0.0-beta.25
@aputinski
Copy link
Author

Did some more digging, and it looks like this RegExp is the culprit:

const findFilename = /(\/((?:[^\/]+?)\.[^\/]+?)|\/)$/;

My server is stripping file extensions, so /iframe.html is rewritten to/iframe which causes the RegExp to no longer match which causes getSourceType to return external

@ndelangen
Copy link
Member

@aputinski do you have a suggestion for a fix?

@stale stale bot added the inactive label Jul 13, 2020
@stale stale bot removed the inactive label Jul 13, 2020
@ndelangen
Copy link
Member

I upgraded this reproduction to the latest RC and it seems fixed already.

@aputinski mind testing it for us? 🙏

@storybookjs storybookjs deleted a comment from stale bot Jul 15, 2020
@aputinski
Copy link
Author

@ndelangen Just upgraded to the latest RC and it's working as expected. Thanks!

@shilman shilman closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants